Fix selection in 3D Game view #101368
Merged
Fix selection in 3D Game view #101368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @YeldhamDev |
akien-mga
reviewed
Jan 9, 2025
Hilderin
force-pushed
the
fix-selection-game-view
branch
from
1d746c4 to
23c172c
Compare
akien-mga
approved these changes
Jan 9, 2025
Hilderin
force-pushed
the
fix-selection-game-view
branch
from
23c172c to
eaee346
Compare
AThousandShips
approved these changes
Jan 10, 2025
Hilderin
force-pushed
the
fix-selection-game-view
branch
from
eaee346 to
055b418
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix the issue for the selection in 3D. I was no able to reproduce the issue in 2D.
The problem was the calculation of the distance between the raycast collision point and the camera position. Since the camera position and the raycast hit point are in global space, we don't need to apply any other transformation to calculate the distance between them.
In addition, the selection did not work on CSG if collision is not enabled. I added support for CSGShape without collision.
Exemple:
godot.windows.editor.dev.x86_64_jlsUhJGWuj.mp4
There's a little MRP project to test:
test-godot-select-game-workspace.zip