-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PICO OS Immersive Mode #101387
Add PICO OS Immersive Mode #101387
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me! Just want to get @m4gr3d approval as well as the expert on the Android build setup.
platform/android/java/lib/src/org/godotengine/godot/utils/DeviceUtils.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Looking forward to having the XR Editor running on a second platform!
Supported features in the immersive preview mode - Passthrough - Hand tracking Notes: - Multi-window is only available for internal apps on PICO OS, therefore launching adjacent windows is not possible currently. - Passthrough splash screen is not supported on PICO OS
293d6ad
to
a2bfb7c
Compare
Thanks! And congrats for your first merged Godot contribution 🎉 |
This is already merged, but I was finally just able to test it on the Pico 4 Ultra. Seems to work great! I'm able to launch an XR project, go into immersive mode, and then quit it to return to the Godot editor. There are some little issues that I noticed: for example, the "Quit to Project List" option doesn't seem to work, the Godot editor just exits. And if I run a 2D project, it will open it in a panel and work fine, but when I close that panel it doesn't take me back to the editor - I have to launch Godot again. But if those represent Godot issues (and not issues in the Pico OS), we can do follow-up PRs for them :-) Thanks! |
I finally had a moment to test as well. David I'm assuming you tested on a Pico 4 Ultra? I tested it on my Pico 4. Similar experience, seems to work like a charm. I only couldn't return to the editor after launching the game. Also I couldn't have the editor open while the game was running though I think this is due to a few things we can only enable once the editor is in the PICO store (if I understood correctly from conversations I had). Other small interface things I think are mostly Godot or PicoOS things, not related to this PR. |
The editor usually pops out a permission screen the first time it's launched in order to request the
@dsnopek Does the panel open in the same window, or in a separate window? |
@m4gr3d I was just able to test on my new Pico 4 Ultra, and it works correctly there. I haven't tried running a 2D app, only an XR app and that works better on the PICO 4 Ultra as well. |
Yep!
I don't recall seeing the permission request, but it's possible it appeared and I just immediately accepted it. :-) I didn't have the problem that Bastiaan had - the default directory that the project manager uses worked fine for me. I was able to pull projects from the asset library into there and they ran fine.
It appears like the game replaces the editor within the same window. If I click on the Godot Editor app on the toolbar, it just hides/shows the game. And then the only thing I can do is close the panel, which quits the game, and the editor is long gone (I suspect it quit as soon as I started the game?) |
Add PICO OS support for the XR preview mode.
When previewing XR projects in Godot Engine running on PICO Headsets (PICO 4 Ultra, PICO 4), the preview mode stays in 2D- windowed mode and does not enter the immersive mode.
This commit enables previewing XR applications in immersive mode on PICO Headsets.