Use GetFileAttributesW
for checking file existence on Windows
#101431
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially address #78645.(solved by #101435)Help to address #100109.
We are using
_wfsopen
inFileAccessWindows::file_exists
which opens a file just to check it is there. UseGetFileAttributesW
makes this function a lot faster. In MRP of #78645 reduce the lag by about a half (measured by eyes, not that accurate).I used to complain that file operations on Windows were very slow. My apologies for wrongly blaming you, Windows :)