Use MethodInfo::get_compatibility_hash()
to generate the hash for MethodBind::get_hash()
and other GDExtension hash clean up
#101449
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #100674,
MethodInfo::get_compatibility_hash()
was added so that virtual methods could have compatibility hashes too.The main goal of this PR is to change
MethodBind::get_hash()
to useMethodInfo::get_compatibility_hash()
so that we have only one, consistent method for generating the hashes.However, doing that turned up a handful of small bugs which this PR also fixes:
GDExtensionSpecialCompatHashes
for themClassDB::bind_method()
that'll print out an error if there's more default arguments than argumentsGetTypeInfo<GDExtensionConstPtr<T>>::VARIANT_TYPE
andGetTypeInfo<GDExtensionPtr<T>>::VARIANT_TYPE
is changed fromVariant::NIL
to the correct value ofVariant::INT
These fixes have to be made for the
MethodBind::get_hash()
change to work, because, while the two methods generate the same exact hashes in the "correct case", they generate different hashes in the "incorrect cases" of the bugs above.