Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change reset timing of the AnimationMixer and Skeleton on save #101450

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Change reset timing of the AnimationMixer and Skeleton on save #101450

merged 1 commit into from
Jan 12, 2025

Conversation

TokageItLab
Copy link
Member

It should reset the AnimationMixer before notification and force the skeleton to update and fire the signal in the notification.

@TokageItLab TokageItLab added this to the 4.4 milestone Jan 11, 2025
@TokageItLab TokageItLab requested a review from a team January 11, 2025 22:14
@TokageItLab TokageItLab requested a review from a team as a code owner January 11, 2025 22:14
This was referenced Jan 11, 2025
Closed
Merged
@akien-mga akien-mga merged commit bb8001c into godotengine:master Jan 12, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@AThousandShips AThousandShips mentioned this pull request Jan 23, 2025
Closed
@TokageItLab TokageItLab mentioned this pull request Jan 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire approved these changes

Assignees
No one assigned
Labels
bug regression topic:animation
Projects
Animation Team Issue Triage
Status: Done
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

BoneAttachment3D transform is saved (Minor annoyance, Git unfriendly)
3 participants
@TokageItLab @akien-mga @fire