Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTL] Add cell option to control if cell is shrunk to its contents width. #101482

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jan 13, 2025

Fixes #101462

Can be used to disable cell shrinking to contents:

[table=3]
[cell expand=10][left][bgcolor=darkred]10%[/bgcolor][/left][/cell]
[cell expand=60][center][bgcolor=darkgreen]60%[/bgcolor][/center][/cell]
[cell expand=30][right][bgcolor=darkblue]30%[/bgcolor][/right][/cell]
[/table]

[table=3]
[cell expand=10 shrink=false bg=white][left][bgcolor=darkred]10%[/bgcolor][/left][/cell]
[cell expand=60 shrink=false bg=yellow][center][bgcolor=darkgreen]60%[/bgcolor][/center][/cell]
[cell expand=30 shrink=false bg=pink][right][bgcolor=darkblue]30%[/bgcolor][/right][/cell]
[/table]

[table=3]
[cell=10][bgcolor=darkred]10%[/bgcolor][/cell]
[cell=60][bgcolor=darkgreen]60%[/bgcolor][/cell]
[cell=30][bgcolor=darkblue]30%[/bgcolor][/cell]
[cell]............................................................................................................................[/cell]
[cell]............................................................................................................................[/cell]
[cell]............................................................................................................................[/cell]
[/table]
Screenshot 2025-01-13 at 10 09 21

@bruvzg bruvzg added this to the 4.x milestone Jan 13, 2025
@bruvzg bruvzg requested review from a team as code owners January 13, 2025 08:08
@bruvzg bruvzg force-pushed the rtl_expand_control branch from 8ffd284 to 26df1cd Compare January 13, 2025 13:04
@akien-mga akien-mga modified the milestones: 4.x, 4.4 Jan 13, 2025
@bruvzg bruvzg force-pushed the rtl_expand_control branch from 26df1cd to 8c927a3 Compare January 13, 2025 13:18
@akien-mga
Copy link
Member

Needs rebase.

@bruvzg bruvzg force-pushed the rtl_expand_control branch from 8c927a3 to b983b9d Compare January 13, 2025 19:44
@akien-mga akien-mga merged commit f8dc6a0 into godotengine:master Jan 13, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@Alexey-Ost
Copy link

I think {ratio} should also be in {options} and work together in one transparent way.
Having separate [cell={ratio}] and [cell {options}] is redundant and misleading.

Anyway, great job!

@akien-mga akien-mga changed the title [RTL] Add cell option to control if cell is shrinked to its contents width. [RTL] Add cell option to control if cell is shrunk to its contents width. Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bbcode cell ratio does not expand cell size
3 participants