-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add has_custom_data()
to TileData
#101488
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd approve but I think this should be added as a method to TileSet
as well, as: has_custom_data_layer
or has_custom_data_layer_by_name
That method would just be:
return custom_data_layers_by_name.has(p_value);
And then have this method call it directly
4256571
to
f434c75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The naming is something I think the team should also weigh in on, but this is a good change IMO, needs a review from the 2D nodes team but otherwise this looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. And I think the naming is good, as it's consistent with get_custom_data_layer_by_name
.
has_custom_data()
to TileData
Thanks! |
This PR adds the method
has_custom_data
toTileData
, allowing users to check if a data layer exists or not.Closes godotengine/godot-proposals#11317