Expose OpenXR action handles to GDExtension #101503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4gr3d
approved these changes
Jan 13, 2025
AThousandShips
approved these changes
Jan 13, 2025
devloglogan
force-pushed
the
openxr-api-action-handle
branch
from
c7f6a2c to
c5e40e1
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes two
OpenXRAPIfunctions for use with GDExtension:find_action()andaction_get_handle(). This makes it so that an extension could get the OpenXRXrActionhandle for a corresponding action by searching for the actions name.Getting access to action handles would be useful in the context of the XR_FB_haptic_amplitude_envelope and XR_FB_haptic_pcm OpenXR extensions, as both extensions require access to the action handle for haptic output.