Remove unused EditorSceneFormatImporter::_get_import_flags
#101531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removing an unused virtual method should be fine. When a virtual method is called, Godot asks the GDExtension if it has an implementation of that virtual method. Removing the virtual method basically means Godot will never ask, which won't lead to any crashes or anything. The only compatibility break would be if existing GDExtensions had implementations of this virtual method, and their functionality depended on it being called. But since it's unused, there shouldn't be any such GDExtensions. |
dsnopek
approved these changes
Jan 14, 2025
This has never been used since Godot was open sourced. Import flags are used but directly through `_import_scene`.
akien-mga
force-pushed
the
scene-import-remove-unused-_get_import_flags
branch
from
75895fd to
21fcb56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has never been used since Godot was open sourced.
Import flags are used but directly through
_import_scene.We normally try not to break compatibility by removing APIs, but since this one really does nothing, it doesn't seem to serve any purpose to keep it until 5.0 (if we ever remember to remove it then).