-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Linux] Implement native color picker. #101546
Conversation
7566d19
to
3d1c4b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on KDE Plasma, works as expected.
3d1c4b8
to
148b03a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally on KDE X11 6.2.5 (with and without single-window mode), it doesn't seem to do anything when clicking the pick color button:
color_picker_not_working.mp4
In comparison, it worked on 4.4.dev 24d7451.
148b03a
to
6a7ea7a
Compare
I'm not sure about adding a new method in DisplayServer. Can this be implemented for other OSes too? |
Added availability checks for |
D-Bus/FreeDesktop portal is already initialized and polled as part of DisplayServer, so it's a logical place to add it to reuse a lot of existing code.
A far as I can tell, no. None of the other OSes have anything like this (macOS and Windows have only full color picker dialogs), but this is likely the only way to pick from a screen on Wayland. |
I tested this PR on sway, and it worked fine even on my clunky KISS Linux setup! I'll do a final approval once #101812 is merged, as this PR includes that. |
6a7ea7a
to
05ca806
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested once again, with successful results, on my funky KISS Linux laptop (sway using xdg-desktop-portal-wlr
backend). Code checks out.
LGTM!
Thanks! |
Implements native color picker on Linux.
Screencast.From.2025-01-14.18-23-18.mp4