Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shortcut for Lookup Symbol action #101565

Merged

Conversation

Hilderin
Copy link
Contributor

This PR is completes the PR #91500 created by @laspencer91

Since there were no concensus on the default shortcut to use, I removed the default shortcut.

image

image

image

Note: it's the first time I edit a PR from a contributor, I created a new PR based on an updated version of the original branch/PR. I'm not sure I did it "the correct way".

Co-authored-by: laspencer91 <laspencer@live.com>
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected.

I still can't think of a good default shortcut for this, so I would leave it as-is for now. If we eventually find a good shortcut to use by default, we can add it in a future PR.

Note: it's the first time I edit a PR from a contributor, I created a new PR based on an updated version of the original branch/PR. I'm not sure I did it "the correct way".

You did it fine 🙂

@akien-mga akien-mga modified the milestones: 4.x, 4.4 Jan 17, 2025
@Repiteo Repiteo merged commit 1351d30 into godotengine:master Jan 17, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jan 17, 2025

Thanks!

@SilverWolveGames
Copy link

Thanks guys for your amazing job !

@AThousandShips AThousandShips changed the title Added shortcut for Lookup Symbol action Add shortcut for Lookup Symbol action Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lookup Symbol shortcut cannot be specified in the Editor shortcut settings
6 participants