[macOS, iOS] Dynamically load MetalFX. #101590
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repiteo
reviewed
Jan 15, 2025
akien-mga
approved these changes
Jan 15, 2025
Comment on lines
+54
to
+55
| if (@available(macOS 13.0, iOS 16.0, tvOS 16.0, *)) { | ||
| MDCommandBuffer *obj = (MDCommandBuffer *)(p_command_buffer.id); |
There was a problem hiding this comment.
We don't need to change this and perform availability checks every frame, as higher-level code already guarantees that we won't use the upscaler on older OSs
Comment on lines
+99
to
+100
| if (@available(macOS 13.0, iOS 16.0, tvOS 16.0, *)) { | ||
| RenderingDeviceDriverMetal *rdd = (RenderingDeviceDriverMetal *)RD::get_singleton()->get_device_driver(); |
There was a problem hiding this comment.
Same here, the higher-level code already guarantees that we won't use the upscaler on older OSs
Comment on lines
+134
to
+135
| if (@available(macOS 13.0, iOS 16.0, tvOS 16.0, *)) { | ||
| RenderingDeviceDriverMetal *rdd = (RenderingDeviceDriverMetal *)RD::get_singleton()->get_device_driver(); |
There was a problem hiding this comment.
And here, this change seems unnecessary, as we guarantee it won't be executed on older OSs
|
See #101614 as I think this is all that is necessary – as the Xcode project is missing a weak-linking of MetalFX |
|
This PR is superseded by #101614 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101585
Tested building, exporting and running with enabled MetalFX upscaling on macOS 15.2 and iOS 18.2.1.
A bit hacky, but dynamically loading stuff from Apple frameworks should be fine for AppStore (not sure if we have any other options apart from providing multiple builds, removing MetalFX upscaling entirely, or bumping min. iOS version all the way to 16.0).