Fix Follow Focus in a rotated ScrollContainer
#101625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rindbee
force-pushed
the
fix-follow-focus-in-rotated-ScrollContainer
branch
from
09e1bc2 to
bfebc48
Compare
Rindbee
changed the title
ScrollContainerScrollContainer
Rindbee
changed the title
ScrollContainerScrollContainer
Rindbee
force-pushed
the
fix-follow-focus-in-rotated-ScrollContainer
branch
from
bfebc48 to
7896969
Compare
Calculate based on the `ScrollContainer`'s space to eliminate possible rotation. The global rect already has applied the rotation, so it should not be used.
Rindbee
force-pushed
the
fix-follow-focus-in-rotated-ScrollContainer
branch
from
7896969 to
b75acc3
Compare
KoBeWi
approved these changes
Jan 26, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculate based on the
ScrollContainer's space to eliminate possible rotation. The global rect already has applied the rotation, so it should not be used.Fix #101622.
002.mp4
Rotate_and_rotate.mp4