Ensure Voxelizer SDF generation uses the correct cell level #101631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
bug
topic:rendering
topic:3d
cherrypick:4.3
Syntaxxor
force-pushed
the
voxel-gi-shadow-fix
branch
from
bc14f10 to
393a13a
Compare
clayjohn
approved these changes
Jan 18, 2025
|
Thanks! Congratulations on your first merged contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a while, there have been strange shadows in VoxelGI lighting. Recently, through testing, I identified that it was essentially placing two copies of the scene in the SDF, one at full scale and one at half scale. Some digging revealed that the SDF texture generator in
Voxelizerwas placing both the lowest (highest cell count) and second-lowest octree levels in the SDF. By changing it to only consider the lowest level, the issue is resolved!Before:
After:
Screenshots taken with the VoxelGI Lighting visualization.
Fixes #84992
Fixes #90976
Fixes #38020
First main engine pull request, so please treat me kindly!