Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Tighten timeout period for all jobs #101712

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Jan 17, 2025

Fixes an issue brought up in RC chat1 where portions of a job stuck in an indefinite loop will only be timed out at the default interval of 6-hours. Now the maximum timeout period for jobs is 2 hours, with the majority being smaller than that:

  • static-checks/godot-cpp: 30 minutes
  • android/ios/web: 60 minutes
  • windows/macos/linux: 120 minutes

Footnotes

  1. https://chat.godotengine.org/channel/buildsystem?msg=RJiJn3G8KxA4tqbp6

@Repiteo Repiteo added this to the 4.x milestone Jan 17, 2025
@Repiteo Repiteo requested a review from a team as a code owner January 17, 2025 19:00
@AThousandShips
Copy link
Member

Looks good, but might be cutting it close with 10 minutes on some of these tests, static tests can run longer if downloads go slow, and unit tests can get stuck for a bit

@Repiteo
Copy link
Contributor Author

Repiteo commented Jan 17, 2025

Bumped up static-checks to 30 minutes & removed the test-specific 10 minute timers

@akien-mga akien-mga modified the milestones: 4.x, 4.4 Jan 17, 2025
@Repiteo Repiteo merged commit 2aa2234 into godotengine:master Jan 17, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants