Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure to load joints with individual config in SpringBone #101729

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

TokageItLab
Copy link
Member

@TokageItLab TokageItLab commented Jan 18, 2025

Fixes #101409 (comment)

The joints were cleared before regenerating the joints, but this discards the joints values set at scene loading timing, so change to clear only when an error occurs.

Also fixed lacking simulation_dirty flag updates with indivisual config.

@TokageItLab TokageItLab added this to the 4.4 milestone Jan 18, 2025
@TokageItLab TokageItLab requested a review from a team January 18, 2025 00:40
@TokageItLab TokageItLab requested a review from a team as a code owner January 18, 2025 00:40
@fire fire changed the title Fix failure to load joints with indivisual config in SpringBone Fix failure to load joints with individual config in SpringBone Jan 18, 2025
@Repiteo Repiteo merged commit 76ecc10 into godotengine:master Jan 20, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jan 20, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants