Wayland: Check selection devices before using them #101779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removing the "needs for testing" tag as the issue is extremely sporadic and unpredictable (happened to me like 5 times in a row and once I actually wanted to study the issue it stopped) and the change improves correctness anyways. |
|
Update: got another streak of issues (for now) and found out that the check does indeed block the crash! If it actually returned, that is... Added the return check and I can attest that, after doing that, I've seen the thing actually print the message and not crash. That said, I still have issues reliably reproducing the thing. Hopefully that's all. |
Looks like we never actually stopped the code from using bad pointers. I even forgot the check in the primary selection code 🤦
Riteo
changed the title
bruvzg
approved these changes
Jan 21, 2025
Repiteo
approved these changes
Jan 21, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #101408.
Looks like we never actually stopped the code from using bad pointers. I even forgot the check in the primary selection code 🤦