Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scene debugger fix for remote debugging without editor running #101784

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

ecosky
Copy link
Contributor

@ecosky ecosky commented Jan 19, 2025

When remote debugging, it's possible for sbox_3d_mesh and sbox_3d_mesh_xray to be invalid. This change simply ensures they are valid so an exception won't be thrown in that case.

This issue presented itself when debugging an app using an attached VSCode debugger without the editor running.

@ecosky ecosky requested a review from a team as a code owner January 19, 2025 01:11
@Faless Faless requested a review from YeldhamDev January 19, 2025 08:33
@akien-mga akien-mga added this to the 4.4 milestone Jan 19, 2025
Copy link
Member

@YeldhamDev YeldhamDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@Repiteo
Copy link
Contributor

Repiteo commented Jan 20, 2025

Could you squash the commits? See PR workflow for instructions.

@ecosky ecosky force-pushed the scene_debugger_fix branch from 02a233b to 226f7ae Compare January 20, 2025 23:31
@ecosky
Copy link
Contributor Author

ecosky commented Jan 21, 2025

Could you squash the commits? See PR workflow for instructions.

Done

@Repiteo Repiteo merged commit 3e91b9d into godotengine:master Jan 21, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jan 21, 2025

Thanks! Congratulations on your first merged contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants