Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix visual shader error when opening a Fresnel node preview #101796

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Fix visual shader error when opening a Fresnel node preview #101796

merged 1 commit into from
Jan 20, 2025

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Jan 19, 2025

@Chaosus Chaosus requested a review from a team as a code owner January 19, 2025 11:48
@Chaosus Chaosus added this to the 4.4 milestone Jan 19, 2025
paddy-exe
paddy-exe approved these changes Jan 19, 2025
View reviewed changes
Copy link
Contributor

@paddy-exe paddy-exe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that 4.4 specific or should be cherry-picked to an earlier 4.x versions?

@Chaosus
Copy link
Member Author

Chaosus commented Jan 19, 2025

Is that 4.4 specific or should be cherry-picked to an earlier 4.x versions?

I guess

@Chaosus Chaosus added the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Jan 19, 2025
QbieShay
QbieShay approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@QbieShay QbieShay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Champion 🙌

@Repiteo Repiteo merged commit cabd792 into godotengine:master Jan 20, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jan 20, 2025

Thanks!

@Chaosus Chaosus deleted the vs_fix_fresnel_preview_bug branch January 21, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QbieShay QbieShay QbieShay approved these changes

@paddy-exe paddy-exe paddy-exe approved these changes

Assignees
No one assigned
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release topic:shaders
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Visual Shader causes error whenever Godot editor restarted
4 participants
@Chaosus @Repiteo @QbieShay @paddy-exe