Fix Floating Game Window Title #101809
Merged
Fix Floating Game Window Title #101809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
approved these changes
Jan 20, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Floating Game Workspace title to match the Game Window title. With this modification, the title will correspond to the game window title when embedding is not enabled.
The main challenge with this issue was ensuring that the Floating Window title is updated when a script changes the title within the game process. Since the Floating Window runs in the editor process, it had no way of knowing when the game title changed. The solution I implemented is to use the remote debugger to send the updated title to the editor.
I believe that using the remote debugger could eventually help resolve other issues where the embedded game window falls out of sync with the editor.
godot.windows.editor.dev.x86_64_37R8RUiVNU.mp4