Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wayland: Release pressed events on application focus out #101819

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

Riteo
Copy link
Contributor

@Riteo Riteo commented Jan 20, 2025

Related to #100713

Looks like I always assumed wrongly that the compositor would send us key release events when unfocusing... It did not.


To test this PR do this:

  1. On an unpatched binary, just keep anything pressed and focus any other window, then release the key. Now notice how tooltips don't show anymore. Press and release the "stuck" key while keeping the game focused and bam, things work again.
  2. On a patched binary, notice how this weird dance does not happen anymore ;)

Looks like I always assumed wrongly that the compositor would send us
key release events when unfocusing... It did not.
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, also consistent with macOS, X11 and Windows display server behavior.

Note for testing: The issue seems to be specific to editor inspector tooltips, but not for simple tooltips of other controls (these are not affected by holding key at all).

@Repiteo Repiteo merged commit e062cd2 into godotengine:master Jan 20, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jan 20, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants