Fix a crash bug in LightmapGI::_assign_lightmaps triggered after reparenting
#101853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmintram
force-pushed
the
jamesrm/lightmapgi-crash-fix
branch
from
8b20344 to
fa7ed3f
Compare
Calinou
added
bug
topic:rendering
crash
topic:3d
cherrypick:4.3
AThousandShips
changed the title
LightmapGI::_assign_lightmaps triggered after reparenting
jamesmintram
changed the title
LightmapGI::_assign_lightmaps triggered after reparentingLightmapGI::_assign_lightmaps triggered after reparenting
|
I tried this PR and it does work as expected. I didn't get Godot to crash without it, though it did spam a lot of errors that went away with the PR. |
…renting After reparenting the LightmapGI node, the following `node` would be initialized to null: Node *node = get_node(light_data->get_user_path(i)); Which would then crash when de-referenced further down. This fix detects which the node has been reparented and clears its users.
akien-mga
force-pushed
the
jamesrm/lightmapgi-crash-fix
branch
from
fa7ed3f to
80096e9
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a crash bug in LightmapGI::_assign_lightmaps triggered after reparenting
After reparenting the LightmapGI node, the following
nodewould be initialized to null:Node *node = get_node(light_data->get_user_path(i));
Which would then crash when de-referenced further down. This fix detects which the node has been reparented and clears its users.