Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RTL] Fix ready signal sent too early in single threaded RTL. #101868

Merged
merged 1 commit into from
Jan 29, 2025
Merged

[RTL] Fix ready signal sent too early in single threaded RTL. #101868

merged 1 commit into from
Jan 29, 2025

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jan 21, 2025

Fixes #101866

@bruvzg bruvzg added this to the 4.4 milestone Jan 21, 2025
@bruvzg bruvzg requested a review from a team as a code owner January 21, 2025 06:44
@KoBeWi
Copy link
Member

KoBeWi commented Jan 28, 2025

The output in the MRP still says

1 lines total, 0 visible

Is this expected?

@bruvzg
Copy link
Member Author

bruvzg commented Jan 28, 2025

Is this expected?

Yes, visible line count is only updated on redraw (not sure if it should be considered a bug, but not directly related to this PR, it's only fixing is_ready() state when finished signal is emitted).

@Repiteo Repiteo merged commit 5310426 into godotengine:master Jan 29, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jan 29, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
bug topic:gui
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

RichTextLabel emits "finished" signal when is_ready() is false
3 participants
@bruvzg @KoBeWi @Repiteo