Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OptionButton.show_popup width #101876

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Fix OptionButton.show_popup width #101876

merged 1 commit into from
Jan 21, 2025

Conversation

scgm0
Copy link
Contributor

@scgm0 scgm0 commented Jan 21, 2025 •
edited
Loading

Replace #101858

embedded window:
屏幕截图_20250121_063239

native window master:
屏幕截图_20250121_063515

native window this pr:
屏幕截图_20250121_062536

@scgm0 scgm0 requested a review from a team as a code owner January 21, 2025 13:38
@bruvzg bruvzg self-requested a review January 21, 2025 13:39
@bruvzg bruvzg added this to the 4.4 milestone Jan 21, 2025
@scgm0 scgm0 mentioned this pull request Jan 21, 2025
Closed
@bruvzg
Copy link
Member

bruvzg commented Jan 21, 2025

Menu sizing on macOS seems to be fine (including shrinking), I'll test on Linux and Windows later.

@YeldhamDev
Copy link
Member

Both work on GNU/Linux as well.

KoBeWi
KoBeWi approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on Windows.

bruvzg
bruvzg approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on macOS, X11 and Windows, seems to work fine.

@Repiteo Repiteo merged commit c7c19eb into godotengine:master Jan 21, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jan 21, 2025

Thanks!

@akien-mga akien-mga changed the title Fix OptionButton::show_popup Fix OptionButton.show_popup Feb 8, 2025
@akien-mga akien-mga changed the title Fix OptionButton.show_popup Fix OptionButton.show_popup width Feb 8, 2025
@Giganzo Giganzo mentioned this pull request Feb 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

@bruvzg bruvzg bruvzg approved these changes

Assignees
No one assigned
Labels
bug topic:gui
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@scgm0 @bruvzg @YeldhamDev @Repiteo @KoBeWi