Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect CPUParticles2D and CPUParticles3D documentation #101883

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

ProgrammerOnCoffee
Copy link
Contributor

Fixes incorrect documentation for CPUParticles2D.color_initial_ramp , CPUParticles3D.color_initial_ramp, and CPUParticles3D.color_ramp. All three properties are documented as being GradientTexture1Ds, but they are actually Gradients.

@ProgrammerOnCoffee ProgrammerOnCoffee requested a review from a team as a code owner January 21, 2025 17:21
@AThousandShips AThousandShips added this to the 4.4 milestone Jan 21, 2025
@Repiteo
Copy link
Contributor

Repiteo commented Jan 22, 2025

Could you squash the commits? See PR workflow for instructions.

@ProgrammerOnCoffee
Copy link
Contributor Author

@Repiteo I have neither Git nor GitHub Desktop. Is it possible to do that on the web?

@AThousandShips
Copy link
Member

Not supported, if you need help please ask and we can do this for you for this PR, but future contributions would have to have this done

@ProgrammerOnCoffee
Copy link
Contributor Author

I would appreciate it if you would help this time. If I ever get into engine development I would be willing to download the necessary tools, but I would rather not have to for something as small as this.

Verified

This commit was signed with the committer’s verified signature.
Calinou Hugo Locurcio
Fixes incorrect documentation for CPUParticles2D.color_initial_ramp
@Calinou
Copy link
Member

Calinou commented Jan 25, 2025

I've squashed commits, so this should be good to merge now.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look good to me.

@Repiteo Repiteo merged commit 7ce0828 into godotengine:master Jan 27, 2025
19 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jan 27, 2025

Thanks! Congratulations on your first merged contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants