Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Make Sub-Resources Unique shortcut focus #101918

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

Yelloween10
Copy link
Contributor

@Yelloween10 Yelloween10 commented Jan 22, 2025

After a shortcut is assigned by the user, the assigned shortcut for "Make Sub-Resources Unique" wasn't working unless the user focused on the inspector tab. This made the shortcut ineffective, as the user would already need to interact with the tab where the operation could be performed manually.

  • Removed the line responsible for setting the shortcut context.

Tested by trying the assigned shortcut without focusing on the inspector tab.

Fixes #93038

@Yelloween10 Yelloween10 requested a review from a team as a code owner January 22, 2025 16:27
@KoBeWi KoBeWi added this to the 4.4 milestone Jan 22, 2025
@KoBeWi
Copy link
Member

KoBeWi commented Jan 28, 2025

After more testing, looks like this causes the shortcut to fire when potentially undesired, e.g. when the filter field in editor log has focus. The menu does not have default shortcuts though, so maybe it's not a problem, idk.

@Yelloween10
Copy link
Contributor Author

I don't think it will cause problems since it doesn't have a default shortcut.
How else could it be fixed?

@KoBeWi
Copy link
Member

KoBeWi commented Jan 28, 2025

I can't think of a better solution right now.

Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fixes the issue, with the caveat mentioned above.
It won't cause serious problems, so we don't need a better fix for now.

@Repiteo Repiteo merged commit ef4940c into godotengine:master Jan 28, 2025
19 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jan 28, 2025

Thanks!

@Yelloween10 Yelloween10 deleted the fix-subresources-shortcut branch January 28, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Sub-Resources Unique shortcut does nothing
3 participants