Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SceneTreeDock::_new_scene_from()'s reset_scale in 3D #101943

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Fix SceneTreeDock::_new_scene_from()'s reset_scale in 3D #101943

merged 1 commit into from
Jan 24, 2025

Conversation

gofastlily
Copy link
Contributor

Fix #101907 as described by #101907 (comment)

A typo snuck into SceneTreeDock::_new_scene_from() that meant reset_scale set the scale to 0 instead of 1 for all axes.

@gofastlily gofastlily requested a review from a team as a code owner January 23, 2025 01:34
@AThousandShips AThousandShips added this to the 4.4 milestone Jan 23, 2025
@Repiteo Repiteo merged commit b381d1b into godotengine:master Jan 24, 2025
19 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jan 24, 2025

Thanks! Congratulations on your first merged contribution! 🎉

@gofastlily gofastlily deleted the fix-101907-save-branch-as-scene-reset-scale branch January 24, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Repiteo Repiteo Repiteo approved these changes

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
bug topic:editor topic:3d
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

"Save branch as scene" with "Reset Scale" sets scale to 0
3 participants
@gofastlily @Repiteo @AThousandShips