Android: Keep swipe-to-dismiss disabled by default #101996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syntaxerror247
force-pushed
the
fix-swipe-to-dismiss
branch
from
683b5cf to
25c5ab4
Compare
m4gr3d
reviewed
Jan 24, 2025
syntaxerror247
force-pushed
the
fix-swipe-to-dismiss
branch
from
25c5ab4 to
581bc43
Compare
m4gr3d
requested changes
Jan 27, 2025
syntaxerror247
force-pushed
the
fix-swipe-to-dismiss
branch
from
581bc43 to
6148f73
Compare
Repiteo
requested changes
Jan 27, 2025
syntaxerror247
force-pushed
the
fix-swipe-to-dismiss
branch
from
6148f73 to
6df21a8
Compare
Repiteo
approved these changes
Jan 27, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #100601, where I added the export option to disable
Swipe to Dismiss, I initially intended to keep this feature enabled by default, assuming the attribute would be ignored on standard Android devices. However, it appears that some devices do not ignore this attribute, leading to unexpected closing behavior.In this PR, I am setting
Swipe to Dismisstofalseby default.