-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ask before restarting project from settings #102017
Ask before restarting project from settings #102017
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works, but note the error in the output tab after pressing Save & Restart
. Not sure if it is relevant to this PR though.
2025-01-25.17-43-23.mp4
The save confirm dialog can't properly appear over other dialogs. It's not directly related to this PR, but makes the fix bugged :/ |
Try it with this: #102070 |
4d61604
to
f482284
Compare
Makes sense, I changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works with: #102070
Tested in single and multi-window modes, and the various different scenarios. Code looks fine.
2025-01-28.11-19-12.mp4
f482284
to
e962bfc
Compare
e962bfc
to
00d8f5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, it works as expected (both from the project settings and editor settings).
Code looks good to me.
Thanks! |
Fixes #43302
If you have only scenes that can be saved automatically, the editor will save them and restart without asking like before.