Add missing cstdint includes for GCC 15
#102022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
bug
topic:thirdparty
cherrypick:4.1
cherrypick:4.2
akien-mga
force-pushed
the
glslang-fix-gcc15
branch
from
410c59e to
1823460
Compare
akien-mga
changed the title
cstdint includes for GCC 15
akien-mga
commented
Jan 25, 2025
| @@ -1,6 +1,7 @@ | |||
| #ifndef _THORVG_H_ | |||
| #define _THORVG_H_ | |||
|
|
|||
| #include <cstdint> | |||
There was a problem hiding this comment.
CC @mgrudzinska
This seems to be included already in thorvg main but not in v0.15.x, would be good if it was included in 0.15.10 or 0.16.0 if such releases are planned.
https://github.com/thorvg/thorvg/blob/v0.15.x/inc/thorvg.h
There was a problem hiding this comment.
@akien-mga #include <cstdint> has been included in v0.15.10, Thanks.
https://github.com/thorvg/thorvg/releases/tag/v0.15.10
Repiteo
approved these changes
Jan 25, 2025
|
Thanks! |
|
Cherry-picked for |
akien-mga
removed
cherrypick:4.1
cherrypick:4.2
hermet
added a commit
to thorvg/thorvg
that referenced
this pull request
Jan 30, 2025
gcc15 is more strict at the header inclusion, thorvg header should specify it since it reply on it. issue: godotengine/godot#102022 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For glslang, that fix was already made upstream with KhronosGroup/glslang@e40c14a, but we're still on an older version.
For thorvg, the fix was made in their
mainbranch but not in thev0.15.xbranch.I've confirmed that this fixes building Godot on Fedora 42 with GCC 15: https://bugzilla.redhat.com/show_bug.cgi?id=2340256