Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing metadata saving for embed size mode #102027

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Add missing metadata saving for embed size mode #102027

merged 1 commit into from
Jan 27, 2025

Conversation

YeldhamDev
Copy link
Member

While there's code to get the saved metadata for the embed size mode, there weren't any for actually saving it.

@YeldhamDev YeldhamDev added this to the 4.4 milestone Jan 25, 2025
@YeldhamDev YeldhamDev requested a review from Hilderin January 25, 2025 16:29
Hilderin
Hilderin approved these changes Jan 25, 2025
View reviewed changes
Copy link
Contributor

@Hilderin Hilderin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a very good point! Thanks for the fix!! Code sound good.

@Repiteo Repiteo merged commit a366f23 into godotengine:master Jan 27, 2025
19 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jan 27, 2025

Thanks!

@YeldhamDev YeldhamDev deleted the missing_game_view_metadata branch January 27, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hilderin Hilderin Hilderin approved these changes

Assignees
No one assigned
Labels
bug topic:editor
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@YeldhamDev @Repiteo @Hilderin