Reimplement _wsl_frame_recv_end_callback()

[gofastlily]

Fix #101811

An extraneous call to clear the PendingMessage was in the original PR #98343, which was moved to _wsl_send_callback() in #100631 in an attempt to fix incoming control frames during a multi-frame message.

This PR seeks to restore the fixed multi-frame logic to _wsl_frame_recv_end_callback() while limiting that callback to text and binary frames only, as originally intended.

[Faless]

As stated in #100631 : The wslay library, somehow unintuitively, will call the frame recv end callback for control frames. This has the side effect that while receiving a long message (i.e. a multi-frame message), if a control frame (e.g. a ping or pong) is received it may seem that a FIN frame has been received, resulting in the current code truncating the message. The library do not provide a way to check the opcode in the callback (you are reading the opcode from the value we store, which is always going to be either a binary or text frame because we only store those). So this is the same as doing no check at all, like we did before #100631 . I'm currently traveling, I'll try the MRP as soon as I can to see why #100631 doesn't appear to be working for you.

…

On Sat, Jan 25, 2025, 21:38 Lily ***@***.***> wrote: @gofastlily <https://github.com/gofastlily> requested review from @godotengine/network on: #102038 <#102038> Reimplement _wsl_frame_recv_end_callback() as a code owner. — Reply to this email directly, view it on GitHub <#102038 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAM4C3W6ZHVV5K54HMKPO2L2MPY6DAVCNFSM6AAAAABV3V2OOSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJWGA3DQMRQG4YDQMY> . You are receiving this because your review was requested.Message ID: ***@***.***>

[gofastlily]

Thanks for taking a look. I'll do some digging too and try to fix my understanding of the situation.

[Faless]

See #102128 for a working fix (tested against the provided MRP).