Fix native popup menus position in embedded windows. #102079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
reviewed
Jan 31, 2025
KoBeWi
reviewed
Jan 31, 2025
Calinou
added
the
cherrypick:4.3
Calinou
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Tested locally, it works as expected on Windows 11 24H2.
canvas_items scaling:
canvas_items scaling + 150% Windows scale:
Note that changes to the Windows display scale only affect Godot after a restart. This applies to its native popups, but also its window border. Compare this with Windows Explorer which updates its scale instantly:
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102060