Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Export] Respect icon/splash screen import settings. #102109

Merged
merged 1 commit into from
Jan 31, 2025
Merged

[Export] Respect icon/splash screen import settings. #102109

merged 1 commit into from
Jan 31, 2025

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jan 28, 2025

Fixes #102097

Instead of using ImageLoader to load icon/splash screen directly, try using ResourceLoader first to ensure files imported as textures follow their import settings.

@bruvzg bruvzg added this to the 4.x milestone Jan 28, 2025
@bruvzg bruvzg requested review from a team as code owners January 28, 2025 06:33
m4gr3d
m4gr3d approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Android section looks good!

akien-mga
akien-mga approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@akien-mga akien-mga modified the milestones: 4.x, 4.4 Jan 30, 2025
@Repiteo Repiteo merged commit 81e17d8 into godotengine:master Jan 31, 2025
19 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jan 31, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4gr3d m4gr3d m4gr3d approved these changes

@akien-mga akien-mga akien-mga approved these changes

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
bug topic:editor topic:export
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

SVG import options are ignored during conversion to a Windows icon on export
5 participants
@bruvzg @Repiteo @m4gr3d @akien-mga @AThousandShips