Fix MASS property particle shader bug
#102143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
bug
topic:shaders
cherrypick:4.3
clayjohn
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Looks good to me. I don't know much about how MASS should behave. But this matches the code that was in Godot 2.x (Godot 3.x didn't have attractors) which I assume matches how the MASS property is supposed to behave.
Internally mass defaults to 1.0, so this won't change existing projects. If anyone attempted to use MASS before the shader would fail to compile. So there is no real risk of breaking anything by fixing this.
|
Thanks! Congratulations on your first merged contribution! 🎉 |
akien-mga
changed the title
MASS property particle shader bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MASS property bug in particle shaders fixed, raised in #102035.