2D: Fix clip children and rendering artefacts #102161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartcarnie
commented
Jan 29, 2025
| @@ -1567,7 +1567,9 @@ void RasterizerCanvasGLES3::_add_to_batch(uint32_t &r_index, bool &r_batch_broke | |||
|
|
|||
| void RasterizerCanvasGLES3::_new_batch(bool &r_batch_broken) { | |||
| if (state.canvas_instance_batches.size() == 0) { | |||
| state.canvas_instance_batches.push_back(Batch()); | |||
| Batch new_batch; | |||
| new_batch.instance_buffer_index = state.current_instance_buffer_index; | |||
There was a problem hiding this comment.
We need to start at the last instance buffer, even when starting the first batch. This is 0 when starting a new canvas draw, but will be non-zero if there are multiple draws in a single canvas draw.
Fixes both GLES3 and RendererRD implementations Closes godotengine#102147
stuartcarnie
force-pushed
the
2d_clip_children
branch
from
acb8ea4 to
0a9cd5e
Compare
|
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #102147
Fixes both GLES3 and RendererRD implementations
Note
This fix also addresses the root cause of #101998, which was that instance buffers were reused in the same draw call, causing rendering artefacts.
Both issues resolved