Fully enable HDR2D when the setting is changed #102177
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I added HDR2D, I ended up making it force a restart when the project setting was changed because the editor would look wrong until restart. There was no technical reason for it, I just couldn't figure out how to change the setting for the editor's root Viewport.
This PR ensures that the setting gets changed for both the SubViewports (2D and 3D which already worked) and the editor root. So now there is no need to restart.
This issue came up today in the rendering meeting as it makes proper HDR a little more awkward CC @DarkKilauea
This issue was also noted by @Calinou in the original PR #80215 (review)