-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to capture scene thumbnails with fixed view #102263
Add an option to capture scene thumbnails with fixed view #102263
Conversation
This looks like a great start 🙂 However, I think this feature should always be enabled, with a way to manually override camera settings for specific scenes. This way, all team members will always see the same thumbnails when working on a project. Therefore, I don't think editor settings should be added here. One way to implement this would be an Override Scene Thumbnail action in the Perspective menu, which would set some editor-only metadata on the scene's root node with the camera mode (perspective/orthogonal), position, rotation and FOV. (Editor-only metadata is metadata whose name starts with a There would also be a Reset Scene Thumbnail action below it, which would remove this metadata. (This action would be grayed out if the scene thumbnail hasn't been overridden yet.)
This should be feasible by hiding all gizmos, waiting 2 frames, taking the screenshot and restoring the previous gizmo state. |
I also think this feature should always be enabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you run precommit?
python install pre-commit
# in godot engine directory
pre-commit run -a
Alternatively you can try copying the diff patch from the repository and git apply diff.patch
manually.
Then try |
Continue with a better approach at #102313 |
Add a setting
docks/filesystem/scene_thumbnail_capture_method
to toggle between FREE / FIXED thumbnail captures, FREE is the default behavior, which captures scene thumbnail by the current camera view. This PR adds a FIXED option to always capture scene thumbnails with a 3/4 fixed view (in 3d), also ensures all visual elements are within the capture.scene_thumbnail_fixed.mp4
TODO: