Use a smaller epsilon for omni and spot attenuation cutoff #102272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We just want to avoid calculating shadows when the attenuation is zero, so we should use the smallest epsilon we can get away with
|
I wonder where this value changed, what caused this problem |
|
The value wasn't changed, it was introduced as an optimization, but the epsilon was too broad for edge cases |
Calinou
approved these changes
Feb 1, 2025
There was a problem hiding this comment.
Tested locally, it works as expected.
Screenshots with debanding enabled:
Forward+
Mobile
There's still banding despite debanding being enabled due to godotengine/godot-proposals#4193 not being implemented yet.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We just want to avoid calculating shadows when the attenuation is zero, so we should use the smallest epsilon we can get away with
Fixes: #102241
Looks great now
