Fix crash when assigning wrong shader to particle process material #102280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chaosus
force-pushed
the
fix_particles_process_shader_crash
branch
from
2e64ee1 to
53e6d30
Compare
AThousandShips
added
cherrypick:4.2
Calinou
approved these changes
Feb 1, 2025
There was a problem hiding this comment.
Tested locally, it works as expected.
While I didn't get a crash on my end when following the steps in #102277 (Linux), this resolves error spam that previously occurred when assigning a fog shader to a property expecting a particle shader.
ERROR: Parameter "pipeline" is null.
at: compute_list_bind_compute_pipeline (servers/rendering/rendering_device.cpp:5060)
ERROR: This compute pipeline requires (0) bytes of push constant data, supplied: (128)
at: compute_list_set_push_constant (servers/rendering/rendering_device.cpp:5189)
ERROR: No compute pipeline was set before attempting to draw.
at: compute_list_dispatch_threads (servers/rendering/rendering_device.cpp:5341)
ERROR: Parameter "pipeline" is null.
at: compute_list_bind_compute_pipeline (servers/rendering/rendering_device.cpp:5060)
ERROR: This compute pipeline requires (0) bytes of push constant data, supplied: (128)
at: compute_list_set_push_constant (servers/rendering/rendering_device.cpp:5189)
ERROR: No compute pipeline was set before attempting to draw.
at: compute_list_dispatch_threads (servers/rendering/rendering_device.cpp:5341)
ERROR: Parameter "pipeline" is null.
at: compute_list_bind_compute_pipeline (servers/rendering/rendering_device.cpp:5060)
ERROR: This compute pipeline requires (0) bytes of push constant data, supplied: (128)
at: compute_list_set_push_constant (servers/rendering/rendering_device.cpp:5189)
ERROR: No compute pipeline was set before attempting to draw.
at: compute_list_dispatch_threads (servers/rendering/rendering_device.cpp:5341)
clayjohn
approved these changes
Feb 11, 2025
|
Thanks! |
akien-mga
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(this bug does not happen on GLES3 (because it has a correct material checking), so I did not change it).