Do not commit gizmo handles if no changes were made #102317
Open
+15
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryevdokimov
force-pushed
the
gizmo-commit-handle-spam-fix
branch
from
950541e to
85993fc
Compare
ryevdokimov
force-pushed
the
gizmo-commit-handle-spam-fix
branch
from
85993fc to
d71a3c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unreverts the 3d gizmo handle part of: #87161
#94684 partially reverted the above-mentioned PR, because it ended up breaking
SoftBody3Dpinned points interaction, but reintroduced the problem in all other 3D gizmos. This PR fixes the problem by makingSoftBody3DGizmoPluginan exception to the mouse movement requirement to interact with gizmo handles.