Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward color picker preview mouse button events to the window underneath. #102343

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Forward color picker preview mouse button events to the window underneath. #102343

merged 1 commit into from
Feb 10, 2025

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Feb 2, 2025

Fixes #102293
Supersede #102320

@bruvzg bruvzg added this to the 4.4 milestone Feb 2, 2025
@bruvzg bruvzg requested a review from a team as a code owner February 2, 2025 22:06
Calinou
Calinou reviewed Feb 3, 2025
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on Windows 11 24H2, it works as expected.

However, I think right-clicking should still abort the color picker. Trying to pan in the 2D editor while picking a color will abort the color picker, but right-clicking elsewhere won't.

@bruvzg
Copy link
Member Author

bruvzg commented Feb 3, 2025

However, I think right-clicking should still abort the color picker.

Added right-click cancel.

@KoBeWi
Copy link
Member

KoBeWi commented Feb 4, 2025

The cancel restores initial color (from before picker was opened), instead of the color before picking.

@bruvzg
Copy link
Member Author

bruvzg commented Feb 8, 2025

The cancel restores initial color (from before picker was opened), instead of the color before picking.

ESC was doing it before, but using color before picking makes more sense, changed it for both ESC and right-click.

@akien-mga akien-mga merged commit 4b5fc25 into godotengine:master Feb 10, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou left review comments

@KoBeWi KoBeWi KoBeWi approved these changes

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
bug platform:macos platform:windows topic:gui
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Color picker picks value when trying to zoom in scene
5 participants
@bruvzg @KoBeWi @akien-mga @Calinou @AThousandShips