Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ColorPicker RAW alpha slider theme #102349

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

Giganzo
Copy link
Contributor

@Giganzo Giganzo commented Feb 2, 2025

Fixes: #102348

SLIDER_COUNT was changed in #101100
This made the apply_theme for color mode RAW in color_mode reset the theme for the alpha slider too.

@Giganzo Giganzo requested a review from a team as a code owner February 2, 2025 23:52
@KoBeWi
Copy link
Member

KoBeWi commented Feb 3, 2025

It would be better to use some constant, so it doesn't break if we decide to change the count again.

@Giganzo Giganzo force-pushed the color-picker-raw-a-slider branch from 4784465 to e50f509 Compare February 3, 2025 15:41
@Repiteo Repiteo merged commit 0f40078 into godotengine:master Feb 3, 2025
19 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Feb 3, 2025

Thanks!

@Giganzo Giganzo deleted the color-picker-raw-a-slider branch February 3, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ColorPicker RAW mode A slider is using wrong theme
5 participants