Fix is_valid_float, Variant parser, Expression parser, script highlighter, and TextServer not handing capital E in scientific notation.
#102396
Conversation
C standard seems to allow both upper and lower case, so probably yes. |
|
Would make sense to add a test for this, wouldn't it? |
|
Should the check be added in syntax_highlighter.cpp too? |
Yes, missed it. Will update in a moment. |
Done, also added few tests. |
| static bool isflt[] = { true, true, true, false, true, true, false, false, false, false, false, false, false, true, true }; | ||
| static bool isaid[] = { false, false, false, false, false, false, false, false, true, true, false, false, false, false, false }; | ||
| static bool isuid[] = { false, false, false, false, false, false, false, false, true, true, false, false, true, false, false }; | ||
| for (unsigned int i = 0; i < sizeof(data) / sizeof(data[0]); i++) { |
There was a problem hiding this comment.
This is not important, but for the future, you can use std::size(data) instead of sizeof(data) / sizeof(data[0]) :)
There was a problem hiding this comment.
Isn't it C++20 only thing.
There was a problem hiding this comment.
Nop, I was wrong it's C++17 (and compiler support is reasonable) so it can be used. Might good cleanup for ~70 currently used cases of sizeof / sizeof.
|
Needs a rebase |
…ighlighter, and `TextServer` not handing capital E in scientific notation.
|
Thanks! |
Fixes #102363