Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enum value lookup jump #102401

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

HolonProduction
Copy link
Member

@HolonProduction HolonProduction commented Feb 4, 2025

Alternative Followup to #101127 that also sets the correct lookup target and script

Fixes #101089

Known issues:

  • With this pr enum values will resolve to a lookup target that points to the actual enum and not only the class containing the enum. The editor is not able to resolve the documentation for this nested target (it is able if the nested element is a class, but it doesn't seem to handle enums). I don't have the insight on how the documentation is resolved to fix this.

@Repiteo
Copy link
Contributor

Repiteo commented Feb 4, 2025

My b on merging the prior PR a bit too quickly; feel free to revert those changes here if you deem it necessary

@HolonProduction
Copy link
Member Author

Nah, no need to revert. Just rebased

akien-mga added a commit to akien-mga/godot that referenced this pull request Feb 7, 2025
@akien-mga akien-mga merged commit 54ffb8a into godotengine:master Feb 7, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ctrl-Click on enum value/member does nothing
4 participants