Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement post-processing levels for VideoStreamPlayer and Theora #102410

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
+666 −403
Draft

Implement post-processing levels for VideoStreamPlayer and Theora #102410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f247532
Fix playing of video Theora files
berarma Jan 23, 2025
db96a44
Implement seek operation in Theora video files
berarma Jan 28, 2025
0b5b235
Use permanent audio buffer
berarma Feb 10, 2025
dcbd694
Add 8-channel audio support
berarma Feb 10, 2025
7d47a3d
Downmix 4/6/8-channel audio to stereo
berarma Feb 10, 2025
5705c69
Clear state before setting new file
berarma Feb 11, 2025
b901571
Dynamic audio buffer size
berarma Feb 11, 2025
aa77130
Don't start decoding video before keyframe
berarma Feb 11, 2025
c834212
Implement post-processing for VideoStreamPlayer
berarma Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions doc/classes/VideoStreamPlayback.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,13 @@
Set the paused status of video playback. [method _is_paused] must return [param paused]. Called in response to the [member VideoStreamPlayer.paused] setter.
</description>
</method>
<method name="_set_pp_level" qualifiers="virtual">
<return type="void" />
<param index="0" name="pp_level" type="int" />
<description>
Set the post-processing level [param pp_level]. Called when playback starts, and in response to the [member VideoStreamPlayer.pp_level] setter.
</description>
</method>
<method name="_stop" qualifiers="virtual">
<return type="void" />
<description>
Expand Down
5 changes: 3 additions & 2 deletions doc/classes/VideoStreamPlayer.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
<return type="float" />
<description>
The length of the current stream, in seconds.
[b]Note:[/b] For [VideoStreamTheora] streams (the built-in format supported by Godot), this value will always be zero, as getting the stream length is not implemented yet. The feature may be supported by video formats implemented by a GDExtension add-on.
</description>
</method>
<method name="get_stream_name" qualifiers="const">
Expand Down Expand Up @@ -74,12 +73,14 @@
<member name="paused" type="bool" setter="set_paused" getter="is_paused" default="false">
If [code]true[/code], the video is paused.
</member>
<member name="pp_level" type="int" setter="set_pp_level" getter="get_pp_level" default="0">
Maximum post-processing level to use. Zero is disabled, the higher the more CPU is used.
</member>
<member name="stream" type="VideoStream" setter="set_stream" getter="get_stream">
The assigned video stream. See description for supported formats.
</member>
<member name="stream_position" type="float" setter="set_stream_position" getter="get_stream_position">
The current position of the stream, in seconds.
[b]Note:[/b] Changing this value won't have any effect as seeking is not implemented yet, except in video formats implemented by a GDExtension add-on.
</member>
<member name="volume" type="float" setter="set_volume" getter="get_volume">
Audio volume as a linear value.
Expand Down
Loading