Fix over saturated static colored lights #102424
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102203
The output of
trace_direct_light()
was multiplied by a color vector twice resulting in over saturation.Since
penumbra_color
is already derived fromlight_color
it shouldn't be necessary to uselight_color
anymore in the final calculation.I tested using:
Both seeme to be fixed:

And

This is the first time I'm diving into lighting, so please double check me.