Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Use AHashMap for RBMap nodes and HashMap input_activity" #102432

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Revert "Use AHashMap for RBMap nodes and HashMap input_activity" #102432

merged 1 commit into from
Feb 5, 2025

Conversation

akien-mga
Copy link
Member

@akien-mga
Revert "Use AHashMap for RBMap nodes and HashMap input_activity"
6d4c2d0 
This reverts commit c91c604.

This caused a critical regression:

- Fixes godotengine#102374.
@akien-mga akien-mga added this to the 4.4 milestone Feb 4, 2025
@akien-mga akien-mga requested a review from a team as a code owner February 4, 2025 19:42
@akien-mga akien-mga mentioned this pull request Feb 4, 2025
Merged
@akien-mga akien-mga changed the title Revert "Use AHashMap for RBMap nodes and HashMap input_activity" Revert "Use AHashMap for RBMap nodes and HashMap input_activity" Feb 4, 2025
fire
fire approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we aren't able to investigate the critical regression of the AnimationTree crash promptly in 4.4, pushing this by reverting to 4.5 to have more time budget makes sense.

@akien-mga akien-mga merged commit 84af487 into godotengine:master Feb 5, 2025
19 checks passed
@akien-mga akien-mga deleted the revert-101548 branch February 5, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire approved these changes

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
bug crash regression topic:animation
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Animation Tree Editor Crashes.
3 participants
@akien-mga @fire @AThousandShips