Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix erroneous logic when flushes are involved on RD async methods. #102454

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

DarioSamo
Copy link
Contributor

Fixes #102406.

When using asynchronous calls, we must make sure to refresh the indices and counts of get data requests if frames are flushed, as the previous values are stale and will lead to out of bounds accesses and glitches if ignored.

@Repiteo Repiteo merged commit 2687833 into godotengine:master Feb 5, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Feb 5, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor crashes when callback for RD::texture_get_data_async is an empty method
4 participants