Add loop annotations to ubershaders to prevent loop unrolling. #102480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayjohn
approved these changes
Feb 6, 2025
akien-mga
added a commit
to akien-mga/godot
that referenced
this pull request
Feb 7, 2025
…shader Add loop annotations to ubershaders to prevent loop unrolling.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99964.
Mesa seems to be able to detect the range that the specialization constant for shadow samples can take and decides to unroll the loop on ubershaders, taking much longer time than we want on compiling them as our goal is not their runtime performance but their creation time.
This could likely result in improvements in other drivers depending on whether they respect the
DontUnrollhint on the resulting SPIR-V.